F5Networks / f5-azure-arm-templates-v2

Azure Resource Manager Templates for quickly deploying BIG-IP services in Azure
22 stars 45 forks source link

Quickstart suggests SSH2 format for sshKey parameter #8

Closed adityoari closed 2 years ago

adityoari commented 2 years ago

Documentation link

https://github.com/F5Networks/f5-azure-arm-templates-v2/blob/main/examples/quickstart/README.md

Describe the problem

README for Quickstart example suggests to use SSH2 format (BEGIN SSH2 PUBLIC KEY) for the sshKey parameter, even though testing and closer looks at the bigip-standalone module are both suggesting that OpenSSH format (ssh-rsa ..) is expected.

From examples/modules/bigip-standalone/bigip.json, line 433:

                "linuxConfiguration": {
                    "disablePasswordAuthentication": true,
                    "ssh": {
                        "publicKeys": [
                            {
                                "keyData": "[parameters('sshKey')]",
                                "path": "[concat('/home/', parameters('adminUsername'), '/.ssh/authorized_keys')]"
                            }
                        ]
                    }
                }

When SSH2-formatted, multi-lines key is used for sshKey parameter, the linked bigipTemplate deployment would fail with InvalidParameter error.

Suggested fix

shyawnkarim commented 2 years ago

Thanks for reporting this issue with our documentation. We are now tracking this work internally with ID ESECLDTPLT-2888.

shyawnkarim commented 2 years ago

Closing.

Our documentation was updated in Release 2.0.0.0.