F5Networks / f5-ci-docs

Documentation for F5's Container Ingress Services
http://clouddocs.f5.com/containers/v2
Apache License 2.0
7 stars 27 forks source link

User guide for installing Openshift Routes with AS3 backend #691

Closed ssurenr closed 5 years ago

ssurenr commented 5 years ago

Reviewer: @kkinch

ssurenr commented 5 years ago

@kkinch https://clouddocs.f5networks.net/containers/latest/openshift/kctlr-use-as3-backend.html looks excellent. Under "supported-openshift-route-features" section, the annotations should come as a list. All other this are good.

kkinch commented 5 years ago

@ssurenr Thank you for your new document, very well written and helpful!

As I understand we're using my modified version. We will link to the new from here:

https://clouddocs.f5networks.net/containers/v2/openshift/

https://clouddocs.f5networks.net/containers/v2/openshift/kctlr-use-as3-backend.html

If this is acceptable, I assume we can close this PR and I'll publish to livesite after go/no-go today.

ssurenr commented 5 years ago

@kkinch Sure. We can go ahead and publish your version. Could you please take care of the following:

  1. Highlight "--agent=AS3" under Enabling AS3 orchestration.
  2. Annotations should be a sub section of Supported Openshift Route Features.
  3. AS3 Resources can be a main section; not listed under Known Issues.
kkinch commented 5 years ago

@ssurenr I have almost all updates. I think you're asking to hightlight --agent=as3 in the code block.

Currently, it's not bolding correctly. Will research this.

https://clouddocs.f5networks.net/containers/v2/openshift/kctlr-use-as3-backend.html

ssurenr commented 5 years ago

Sure. No problem. Thanks @kkinch .