search

F5Networks / f5-cloud-libs-azure

Azure specific implementations for f5-cloud-libs
Apache License 2.0
6 stars 1 forks source link

Remove unused ajv and request dependencies #9

Closed dstokesf5 closed 5 years ago

dstokesf5 commented 5 years ago

As far as I can tell, these two modules are no longer in use in this code base. The request module is causing some problem on TMOS v12.1.0-12.1.2 by indirectly depending on an old version of AJV. That old version of AJV uses some file names that contain "$", which causes problems when creating UCS backups.

I was having a hard time running the unit tests, do you have some documentation on how to run them? In particular I was having some problems with the f5-cloud-lib peer dependency and an unlisted winston dependency.

dstokesf5 commented 5 years ago

I got the unit tests figured out. I needed to do an npm install in f5-cloud-libs. All the tests are passing with this change.