search

F5Networks / f5-google-gdm-templates-v2

Google Deployment Templates for quickly deploying BIG-IP services in Google Cloud Platform
5 stars 13 forks source link

restrictedSrcAddressApp required but missing in failover example yaml files #10

Closed JeffGiroux closed 2 years ago

JeffGiroux commented 2 years ago

Describe the bug

The parameter 'restrictedSrcAddressApp' is set to be required 'yes' but it is not listed in the example yaml files. As a result, if user uses example failover yaml file, it is missing the parameter. The deployment will fail in google when python template tries to read the value.

Expected behavior

User should be able to pull down example yaml file that indicates all required and/or optional values. This way user is forced to enter values into yaml that are required and missing.

Current behavior

Parameter is required, but it is missing from example yaml. GCP deployment fails with an error that the parameter and value is basically missing.

Possible solution

Make sure that the restrictedSrcAddressApp parameter is in the example yaml files as required for all templates. For reference, this is found in the Quickstart yaml example files but not failover. I did not check other templates.

Add this to the 'sample_failover_existing_network.yaml' for example...

      # restrictedSrcAddressApp:*
      # 0.0.0.0/0**
      restrictedSrcAddressApp:

Steps to reproduce

  1. clone repo, update yaml file, update runtime init file
  2. launch bigip deployment
  3. fails with missing parameter

Screenshots

n/a

Context

n/a

Your Environment

n/a

shyawnkarim commented 2 years ago

Thanks for reporting this. I've added it to our backlog and it is being tracked with internal ID, ESECLDTPLT-3137.

shyawnkarim commented 2 years ago

Closing.

This issue was resolved with Release 2.4.0.0.

JeffGiroux commented 2 years ago

This is not fixed. The yaml file in failover existing is still missing the required parameter.

https://github.com/F5Networks/f5-google-gdm-templates-v2/blob/main/examples/failover/sample_failover_existing_network.yaml

shyawnkarim commented 2 years ago

Thanks for letting me know. This was improperly marked done and is still open in our backlog.

shyawnkarim commented 2 years ago

Thanks for letting me know. This was improperly marked done and is still open in our backlog.

shyawnkarim commented 2 years ago

Closing. This issue was resolved (for real this time) with Release 2.5.0.0.