F5Networks / f5-google-gdm-templates-v2

Google Deployment Templates for quickly deploying BIG-IP services in Google Cloud Platform
5 stars 13 forks source link

add sections to provide optional Spot VM provision #18

Open vadaszgergo opened 2 years ago

vadaszgergo commented 2 years ago

Is your feature request related to a problem?

To be able to deploy Spot VM, to save costs. I'm using this deployment for lab and learning purposes and for me it makes sense to save cost with this feature.

Describe the solution you'd like

Same as i requested in this commit under gdm-templates-v1 https://github.com/F5Networks/f5-google-gdm-templates/pull/77/commits/109cd4d256a54c584dbe3d98f5b13aa013501279

Describe alternatives you've considered

Additional context

https://cloud.google.com/compute/docs/instances/spot

mikeshimkus commented 2 years ago

Hi @vadaszgergo, I created internal issue #3220 to track adding this feature to the parent templates.

You can achieve this right now by adding the scheduling attribute to the parent template bigip instance config; in the quickstart template here, for example: https://github.com/F5Networks/f5-google-gdm-templates-v2/blob/f2f8160a6407adbd4f42daa8f94ebc56b84b8d0e/examples/quickstart/quickstart.py#L124

Have a look at https://github.com/F5Networks/f5-google-gdm-templates-v2/tree/main/examples/quickstart#changing-the-big-ip-deployment for more info on customizing the templates.

vadaszgergo commented 2 years ago

Hi @mikeshimkus, I understand and I can do it myself, but do you think it would be worthwhile to add the section permanently to the code, so other users could use it out of the box?

mikeshimkus commented 2 years ago

Possibly, we'll review the issue and decide whether or not to expose this as a new input to the templates.

vadaszgergo commented 2 years ago

Thank you. Feel free to close the issue.

shyawnkarim commented 2 years ago

@vadaszgergo, in order to prioritize and understand the issue better, can you reach out to us at s.karim@f5.com?