F5Networks / f5-google-gdm-templates-v2

Google Deployment Templates for quickly deploying BIG-IP services in Google Cloud Platform
5 stars 12 forks source link

GCP Client Secret #24

Closed huzer1 closed 4 months ago

huzer1 commented 4 months ago

Describe the bug

In the runtime init, it appears there's something wrong with the GCP stored password. The password I'm using is Jk198676! (I won't use this password again...)

I created the password using the command from the documentation. echo -n 'Jk198676!' | gcloud secrets create mySecretId --data-file=- ; history -d $(history 1)

Expected behavior

A successful run of runtime init

Current behavior

2024-05-20T20:47:59.385Z [3798]: error: GCP Cloud Client secret id mySecretId is the wrong format

Steps to reproduce

I deployed the failover GCP template with the bare minimum settings. Full network stack and application. https://github.com/F5Networks/f5-google-gdm-templates-v2/tree/main/examples/failover

Your Environment

Test environment currently.

mikeshimkus commented 4 months ago

Hi @huzer1, can you share the input parameters file you used to deploy, specifically what was used for bigIpSecretId: https://github.com/F5Networks/f5-google-gdm-templates-v2/blob/d543fb234672ec2246ddaa512c69a5d940a24217/examples/failover/sample_failover.yaml#L91

And what was saved in /config/cloud/secret_id on the BIG-IPs?

huzer1 commented 4 months ago

It was mySecretId

I couldn't log into the BIG-IP's to find that file.

mikeshimkus commented 4 months ago

You should be able to login as admin with any SSH key that was in your Google Cloud project when you deployed.

huzer1 commented 4 months ago

The contents of /config/cloud/secret_id mySecretId

mikeshimkus commented 4 months ago

I see the problem now, our regex doesn't account for uppercase: https://github.com/F5Networks/f5-bigip-runtime-init/blob/2c560d743669c251ab50d03cf19d2404600195c4/src/lib/cloud/gcp/cloudClient.ts#L79C36-L79C55

For now you should be able to create the secret with the name "mysecretid" instead.

huzer1 commented 4 months ago

Thanks, @mikeshimkus! I'm not sure which is proper, should I closed it as completed?

mikeshimkus commented 4 months ago

I created internal issue EC-515 against runtime init for this. You can close this as it's not a template issue per se.