Enable HTTP Proxy support in the iControlRESTTokenAuth object by passing the proxies from iControlRESTSession object down into it, and applying it to the request.<verb> calls that take place in that module.
Where should the reviewer start?
icontrol/authtoken.py, line 58, then follow it through the self.proxies value in that object.
icontrol/session.py, line 432, then follow where self.proxies was passed as an argument to the underlying token/auth object.
Any background context?
This change is required for full HTTP Proxy functionality.
Otherwise, while the outer requests.Session object in iControlRESTSessiondoes attempt to utilize the proxies provided to it, the inner token acquisition and validation methods in iControlRESTTokenAuth fail as they do not know about the proxy.
lykinsbd
commented
4 years ago
@jasonrahm
What issues does this address?
Fixes #172
What's this change do?
Enable HTTP Proxy support in the
iControlRESTTokenAuthobject by passing theproxiesfromiControlRESTSessionobject down into it, and applying it to therequest.<verb>calls that take place in that module.Where should the reviewer start?
icontrol/authtoken.py, line 58, then follow it through the
self.proxiesvalue in that object.icontrol/session.py, line 432, then follow where
self.proxieswas passed as an argument to the underlying token/auth object.Any background context?
This change is required for full HTTP Proxy functionality.
Otherwise, while the outer
requests.Sessionobject iniControlRESTSessiondoes attempt to utilize the proxies provided to it, the inner token acquisition and validation methods iniControlRESTTokenAuthfail as they do not know about the proxy.