F5Networks / f5-ipam-controller

The F5 IPAM Controller runs in an orchestration environment like Kubernetes to allocate IP addresses from an IPAM system to BIG-IP Virtual Servers. The purpose is to abstract complexity related to setting up BIG-IP from a networking perspective
Apache License 2.0
10 stars 16 forks source link

Add PVC creation to Helm chart #96

Closed andreasjacobi closed 2 years ago

andreasjacobi commented 2 years ago

Title

Add PVC creation to Helm chart

Description

To simplify the deployment of the IPAM controller I suggest you add the PVC creation part as well to it.

Actual Problem

When deploying FIC using Helm you must first create the PVC separately and point to that PVC in the FIC Helm value file.

Solution Proposed

I suggest you add something like Grafana does to the Helm values file so that FIC can be deployed in one go using Helm only:

persistence:
  type: pvc
  enabled: false
  storageClassName: default
  accessModes:
    - ReadWriteOnce
  size: 0.1Gi

If you see a use case for not creating the PVC using Helm then perhaps give an option to enable/disable it.

trinaths commented 2 years ago

Created [CONTCNTR-3141] for internal tracking.

vklohiya commented 2 years ago

Closing the issue as PR is merged and will be available with CIS 2.9.1 Release and FIC charts 0.0.2 release.