F5Networks / k8s-bigip-ctlr

Repository for F5 Container Ingress Services for Kubernetes & OpenShift.
Apache License 2.0
351 stars 193 forks source link

Support for multiple LTM monitors when using HostGroup #3442

Open thomas-cripps-fg opened 1 month ago

thomas-cripps-fg commented 1 month ago

Title

Support for multiple LTM monitors on a pool when virtual server using HostGroup

Description

When deploying multiple virtual server configurations when also using HostGroup LTM monitors appear to overwrite themselves, unsure if RFE or Bug.

Actual Problem

Unable to monitor multiple applications in same backend pool as LTM monitors overwrite themselves. When a batch of VirtualServer CRDs are deployed it seems like the last CRD in the batch is the LTM monitor which persists giving the illusion of appending configuration

Solution Proposed

Allow support for multiple LTM monitors within same backend pool and the use of MinimumMonitors allows the pool not to go down

Alternatives

Unsure if anything else would work

Additional context

N/A

mdditt2000 commented 1 month ago

@thomas-cripps-fg please follow the example https://github.com/F5Networks/k8s-bigip-ctlr/blob/master/docs/config_examples/customResource/VirtualServer/HealthMonitor/monitors-virtual-server.yaml

Schema should allow this. Add HostGroup to the example. Let me know the results or share your CRD to automation_toolchain_pm@f5.com

mdditt2000 commented 1 month ago

re-opened. Let me review this with my team.

thomas-cripps-fg commented 1 month ago

Thanks Mark.

Issue seems to be when we have multiple virtual server CRDs all using the same virtual server and pool due to the use of HostGroup

trinaths commented 1 month ago

@thomas-cripps-fg Please follow the example https://github.com/F5Networks/k8s-bigip-ctlr/blob/2.x-master/docs/config_examples/customResource/VirtualServer/HealthMonitor/monitors-virtual-server.yaml and share your feedback.

thomas-cripps-fg commented 1 month ago

Hi Trinath,

The CRD is not a problem here, we can confirm that is working.

The behaviour we see seems to relate to configuration being overwritten, appreciate AS3 is declarative but with HostGroup does that change anything?

mdditt2000 commented 1 month ago

@thomas-cripps-fg @trinaths lets take this conversation off GitHub and schedule a meeting to see whats going on. I will send a email.

thomas-cripps-fg commented 1 month ago

Thanks Mark.

FYI I’m UK based so BST right now

Tom Cripps

Digital Platform & Network Security Manager

[cid:img_c83ded47-7f94-4294-a5d8-ba09255268b9.jpg]

PHONE

0344 245 9200

ADDRESS

Unit A Brook Park East, NG20 8RY

EMAIL DISCLAIMER All statements made in this email, including in the attachments, are subject to contract. The contents are not to be regarded as a contractual offer or acceptance unless expressly stated otherwise. Frasers Group Plc is a public limited company incorporated in England (Company No 6035106) with its registered office at Unit A, Brook Park East, Shirebrook, NG20 8RY. This disclaimer also incorporates our full terms and conditions which can be found herehttps://frasers.group/legal/disclaimer.

From: mark dittmer @.> Date: Wednesday, 5 June 2024 at 18:13 To: F5Networks/k8s-bigip-ctlr @.> Cc: Tom Cripps @.>, Mention @.> Subject: Re: [F5Networks/k8s-bigip-ctlr] Support for multiple LTM monitors when using HostGroup (Issue #3442)

@thomas-cripps-fghttps://github.com/thomas-cripps-fg @trinathshttps://github.com/trinaths lets take this conversation off GitHub and schedule a meeting to see whats going on. I will send a email.

— Reply to this email directly, view it on GitHubhttps://github.com/F5Networks/k8s-bigip-ctlr/issues/3442#issuecomment-2150562904, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3ADS7LWPYLXKK4PQSI2JILZF5BKJAVCNFSM6AAAAABIRJX5B2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQGU3DEOJQGQ. You are receiving this because you were mentioned.Message ID: @.***>