F5Networks / k8s-bigip-ctlr

Repository for F5 Container Ingress Services for Kubernetes & OpenShift.
Apache License 2.0
364 stars 195 forks source link

[LOGS] improve log message Finished syncing virtual servers xxx in namespace yyy(199.218µs), 1/7 #3520

Open alonsocamaro opened 3 months ago

alonsocamaro commented 3 months ago

Title

improve log message Finished syncing virtual servers xxx in namespace yyy(199.218µs), 1/7

Description

Actual Problem

The message is confusing

Solution Proposed

Rewrite the log message as follows:

"Finished syncing virtual servers with service xxx in namespace yyy (199.218µs), <description of what is x/x>"

Alternatives

i don´t know what x/x means but maybe it would be more useful to indicate which services are used to populate virtual servers:

"Finished syncing virtual servers with service xxx in namespace yyy (199.218µs): updated x, deleted y"

alonsocamaro commented 3 months ago

Rechecking the logs I find the following might be of interest as well:

2024/08/11 22:57:14 [DEBUG] [CORE] Updated 1 of 0 virtual server configs, deleted 0
2024/08/11 22:57:14 [DEBUG] [CORE] Finished syncing virtual servers a-svc in namespace prod (199.218µs), 1/7
2024/08/11 22:57:14 [DEBUG] [CORE] Finished syncing virtual servers b-svc in namespace prod (944ns), 2/7
2024/08/11 22:57:14 [DEBUG] [CORE] Finished syncing virtual servers c-svc in namespace prod (546ns), 3/7
2024/08/11 22:57:14 [DEBUG] [CORE] Finished syncing virtual servers d-svc in namespace prod (399ns), 4/7
2024/08/11 22:57:14 [DEBUG] [CORE] Finished syncing virtual servers f-svc in namespace prod (374ns), 5/7
2024/08/11 22:57:14 [DEBUG] [CORE] Finished syncing virtual servers g-svc in namespace prod (468ns), 6/7
2024/08/11 22:57:14 [DEBUG] [CORE] Finished syncing virtual servers  in namespace prod (5.245µs), 7/7
2024/08/11 22:57:14 [DEBUG] [CORE] Updated 0 of 0 virtual server configs, deleted 0
2024/08/11 22:57:14 [DEBUG] [CORE] Finished syncing virtual servers b-svc in namespace prod (409.123µs), 7/7
trinaths commented 3 months ago

Created [CONTCNTR-4848] for internal tracking.