search

F5Networks / marathon-bigip-ctlr

Repository for F5 BIG-IP Controller for Marathon.
Apache License 2.0
3 stars 11 forks source link

Add label back to docker build command. #245

Closed ryan-talley closed 6 years ago

ryan-talley commented 6 years ago

Problem: The deletion of the --label argument is causing errors in the Jenkins build. The problem is that the controller tag is not being set which causes the $(systest_pkg) to be invalid. That variable is set in the Makefile and is used as an argument to run_systests.sh.

Solution: Add --label back into the docker build to make sure the tag is set.

ryan-talley commented 6 years ago

Adding @michaeldayreads

ryan-talley commented 6 years ago

This is looking like a more involved fix then simply adding back --label BUILD_STAMP=$BUILD_STAMP to the docker build script and probably involves making changed to the versioning tooling. I am going to close this review and file an issue which can be referenced here: https://github.com/F5Networks/marathon-bigip-ctlr/issues/246