F5Networks / neutron-lbaas

Clone of the OpenStack project neutron-lbaas
Apache License 2.0
1 stars 10 forks source link

Teardown robustness needed in tempest tests #45

Closed pjbreaux closed 7 years ago

pjbreaux commented 7 years ago

@szakeri @jlongstaf

This is a cherry-pick of the test teardown robustness into newton. Don't merge until we've rolled a new test container and tested these changes

Issues: Fixes #43

Problem: Our tempest tests are not immune to test interactions. We need to harden the test teardown process as much as we can currently, allowing tests to properly teardown resources created by the test through the proper channels (neutron REST api). This just means making the cleanup calls for the tests and test suites be more flexible in the way it detects and moves around errors.

Analysis: Moved teardown logic for api tests into the neutron-lbaas repo, so the driver can benefit from the code as well. This means that two PRs will be in flight for this change, one to move the logic over to this repo, and one to remove the logic in the driver.

Tests: Ran tests against my local fork. Saw an intermittent Bad Status Line failure in the test_listener_basic scenario test, but I haven't nailed down the cause, other than bad test assumptions. Will keep an eye on this in nightly.

pjbreaux commented 7 years ago

Ok ran the tests and they look normal. There are failures that will hopefully be addressed by additional test-bug-fixes in the driver repo.