search

F5Networks / terraform-aws-bigip-module

Terraform module for Deploying BIG-IP in AWS
Apache License 2.0
10 stars 21 forks source link

feat: ebs volume options ✨ #49

Closed b-diggity closed 1 year ago

b-diggity commented 1 year ago

adding a number of ebs volume options for customers to make updates. this pr is backwards compatible of existing deployments

  1. allowing users to encrypt their ebs volumes (with the aws default or kms cmk). this is currently set false with no way to change it. new input option: ebs_volume_encryption
  2. allowing users to pass in a kms cmk for the volume encryption. turning on encryption, but leaving the kms key arn blank will result in the aws default key being used. currently this doesn't matter since encryption is not possible. new input option: ebs_volume_kms_key_arn
  3. allowing users to set their volume type. the volume type is currently set to gp2 with no way to change it. the new input option ebs_volume_type will allow for other volumes to be used, like gp3
rssnyder commented 1 year ago

encryption FTW!

RavinderReddyF5 commented 1 year ago

Hi @b-diggity Thanks for your PR. will work on review changes and merge it to module. meanwhile can you please submit CLA

b-diggity commented 1 year ago

I closed this PR due to the requirement that I have to fill out that CLA. It's a sad day for anyone that would be apt to contribute but won't because of the CLA... 😥