search

F5Networks / terraform-aws-bigip-module

Terraform module for Deploying BIG-IP in AWS
Apache License 2.0
10 stars 21 forks source link

Update the minimum required version #53

Closed b-diggity closed 1 year ago

b-diggity commented 1 year ago

52 introduced a change that requires a minimum AWS provider version of 5.0.0. Please update the required minimum provider: https://github.com/F5Networks/terraform-aws-bigip-module/blob/main/terraform.tf

b-diggity commented 1 year ago

Also, I see a fix release was created at v1.1.15, but since #50 via #52 requires a new minimum version, maybe a major version would be better?

FWIW, I tested the aws_eip resource update running AWS provider 4.52.0 and got an error regarding the "vpc" input since it was only introduced in v5.

Ultimately, anyone's pipeline still on <5 that is pulling in bug fix releases or minor releases will start failing due to this change on the resource. Making this release major means it's a breaking change and would align better with the result.

pgouband commented 1 year ago

Hi,

Thanks for reporting. Added to the backlog and internal tracking ID for this request is: INFRAANO-1288.