FAAM-146 / decades-ppandas

1 stars 0 forks source link

Flagging modules and their docs assume DecadesBitmaskFlag #20

Open davesproson opened 2 years ago

davesproson commented 2 years ago

Both flagging modules and the preprocessing which provides documentation for these assume DecadesBitmaskFlags are being used, and will not work with DecadesClassicFlag.

For example, in the documentation (ppodd.docs.data.preproc.get_flagmod_doc)

  for var in module.flagged:
        v = DecadesVariable(
            pd.Series(flag, index=index, name=var),
            flag=DecadesBitmaskFlag
        )

And in ppodd.flags.base.FlaggingBase only add_mask is defined, with no equivalent for adding to a DecadesClassicFlag.