FAAM-146 / decades-ppandas

1 stars 0 forks source link

Getting a module test_instance assumes all inputs are 1hz #6

Closed davesproson closed 2 years ago

davesproson commented 3 years ago

This causes an issue on branch lowmem, as the full index isn't stored, and having a .array which isn't the same size as t0..t1..freq causes massive issues. Test instances are currently only really used for documentation, so we can currently work around this issue, but it does need to be addressed.

davesproson commented 3 years ago

Manifests as this error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/dave/miniconda3/envs/decades-ppandas/lib/python3.7/ppodd/decades/decades.py", line 114, in __getattr__
    return getattr(self(), attr)
  File "/home/dave/miniconda3/envs/decades-ppandas/lib/python3.7/ppodd/decades/decades.py", line 87, in __call__
    self.array, index=i, name=self.name
  File "/home/dave/miniconda3/envs/decades-ppandas/lib/python3.7/site-packages/pandas/core/series.py", line 292, in __init__
    f"Length of passed values is {len(data)}, "
ValueError: Length of passed values is 100, index implies 3169.
davesproson commented 3 years ago

Note that this isn't now just an issue on lowmem, has been merged into master.

davesproson commented 2 years ago

Think this has now been adequately addressed. Closing.