FABLE-3DXRD / ImageD11

ImageD11 is a python code for identifying individual grains in spotty area detector X-ray diffraction images.

https://imaged11.readthedocs.io/

GNU General Public License v2.0

15 stars 24 forks source link

3DXRD/S3DXRD notebooks should contain no complicated functions #246

Closed jadball closed 1 month ago

jadball commented 6 months ago

The purpose of the notebooks should just be to choose the data to process and plot the results of that processing. This will make creating workflows much easier. This process should happen in two stages:

Move functions out of notebooks into nb_utils.

This ensures that the functions work from a standalone Python file

Move the functions from nb_utils into existing/new parts of ImageD11

jadball commented 6 months ago

251 removed functions from notebooks

257 worked out where the functions should go

Current task is to actually move them into ImageD11

jadball commented 6 months ago

@jonwright I have made some progress in distributing the functions into ImageD11 in my fork if you want to have a look: https://github.com/jadball/ImageD11

However, it's still in progress so I wasn't planning on making a PR yet. Do you anticipate any core changes to ImageD11 early next week? If so, I could submit a PR now to maintain linearity while i'm away next week.

jonwright commented 6 months ago

Just saw this - feel free to merge. I think I added something to speed up updateGeometry but there should be no conflicts.

jadball commented 1 month ago

Think this is now achieved