search

FABLE-3DXRD / ImageD11

ImageD11 is a python code for identifying individual grains in spotty area detector X-ray diffraction images.
https://imaged11.readthedocs.io/
GNU General Public License v2.0
15 stars 25 forks source link

Fix strain to stress conversion in TensorMap class, better TensorMap documentation #345

Closed jadball closed 2 weeks ago

jadball commented 4 weeks ago

We now compute the Biot stress tensor in the crystal reference frame (ImageD11 convention), given a Biot strain tensor in the crystal reference frame (ImageD11 convention, the default obtained when calling ImageD11.grain.eps_crystal_matrix(dzero_cell)) and a 6x6 stiffness tensor (Voigt-compatible, IEEE 1976 lattice convention, what materialsproject.org gives you).

Thanks to @AxelHenningsson and @jonwright for discussions on this. Partially fixes #194 - the dream is to move the Numba kernels from tensor_map.py into stress.py eventually

review-notebook-app[bot] commented 3 weeks ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jadball commented 3 weeks ago

The IEEE <-> ImageD11 rotation has now been removed from tensor_map.py - are you happy now to merge? The documentation changes are still good and I think the rest of the stress to strain conversion is still valid.

jonwright commented 3 weeks ago

Sure - go for it.