Closed jonwright closed 8 months ago
Hey, 😃
Out of curiosity was it a clean environment with python 3.10 that got you that error, or did you already have some stuff in the env that forced the pin on numpy (maybe ImageD11)?
I think that bumping to python 3.11 at this point should be unproblematic. 👍 I would love a pull request. ❤️ thanks.
Cheers Axel
Oops - I have just pushed directly onto this repo - sorry. Probably I need to reconfigure something to prevent that in the future? I guess the pip message about numpy is wrong or misleading. Anyway, I removed the upper python version limit in 39e91632 so it may break on a future python release, but at least we will find out.
Hi Axel, I just tried to install with a draft environment for the ESRF site conda and I got an error with the version on pip (below). With a git checkout I just needed to bump to allow python 3.11 and then pytest in xrd_simulator/tests is passing.
Shall I send a pull request or is there a reason to avoid python 3.11?
Thanks!
Jon