search

FAC-11 / AllAboutMe

An app to help young people at Anna Freud centre to easily transition to adult care
https://allaboutme-af.herokuapp.com/
10 stars 6 forks source link

404 not found page #141

Closed dangerdak closed 6 years ago

dangerdak commented 6 years ago

Adds function to app.js to render 404 error page if route is unrecognised.

Styles error page with penguin, speech bubble and background image.

codecov-io commented 6 years ago

Codecov Report

Merging #141 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #141   +/-   ##
=====================================
  Coverage      75%    75%           
=====================================
  Files           8      8           
  Lines         144    144           
=====================================
  Hits          108    108           
  Misses         36     36

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30ddc1d...4140464. Read the comment docs.

dangerdak commented 6 years ago

is it ok that the error page doesn't display the status code?

sohilpandya commented 6 years ago

Yep, User need not to worry about error codes, as long as they are aware of what has gone wrong with a descriptive message and next steps for them. :)