search

FAC-11 / AllAboutMe

An app to help young people at Anna Freud centre to easily transition to adult care
https://allaboutme-af.herokuapp.com/
10 stars 6 forks source link

Controller helpers files now moved #181

Closed polyccon closed 6 years ago

polyccon commented 6 years ago

As per #177 all 4 files validate, check_email, helpers, passwordModule now moved into a controllers/helpers directory.

codecov-io commented 6 years ago

Codecov Report

Merging #181 into master will decrease coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   68.42%   68.34%   -0.08%     
==========================================
  Files          26       26              
  Lines         418      417       -1     
==========================================
- Hits          286      285       -1     
  Misses        132      132
Impacted Files Coverage Δ
src/controllers/helpers/check_email.js 75% <ø> (ø)
src/controllers/helpers/generate_token.js 100% <ø> (ø)
src/controllers/helpers/passwordModule.js 100% <ø> (ø)
src/controllers/helpers/validate.js 100% <ø> (ø)
src/controllers/signup.js 75% <100%> (ø) :arrow_up:
src/controllers/reset.js 37.83% <100%> (ø) :arrow_up:
src/controllers/login.js 89.47% <100%> (ø) :arrow_up:
src/controllers/forgot.js 34.37% <100%> (ø) :arrow_up:
src/controllers/send.js 39.13% <100%> (-2.54%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 75cadff...879c337. Read the comment docs.

polyccon commented 6 years ago

Good shout, file renamed to generate_token. Do you think we should move the requiredLogin file in there too?

dangerdak commented 6 years ago

Hm, I'm not sure as @sohilpandya said 'the controller directory should contain information related to the controllers that are being handled by endpoints' and requireLogin is directly related to how the controllers are handled so maybe he left it out on purpose?