FAC-Sixteen / Remindly

Birthday App Reminder
https://remindly-app.herokuapp.com/
MIT License
3 stars 3 forks source link

Mislaid blocks of code #53

Open sima-qian opened 5 years ago

sima-qian commented 5 years ago

I've noticed in a couple of places there exist two very similar blocks of code -- generally the first block has a problem and the second block does not. An example in /src/controllers/addContact.js: the getEventList() -> getGroupList() chain is duplicated. The first time, neither is passed an argument, which causes an error; the second time both are passed the user's email address and the queries are able to execute.

Commenting out the first block means the request is deal with successfully, the event list and group list dropdowns are populated and the server doesn't crash.

My best guess is this is a merge that has gone awry somewhere?

The other file where this occurs is /src/controllers/postGroup.js