search

FAC-Sixteen / Week6-project-Onions

Week 6 database project
https://lost-and-fac.herokuapp.com/
0 stars 1 forks source link

this is my input #28

Open Fweddi opened 5 years ago

Fweddi commented 5 years ago

Lines 22 and following in your script file:

            const inputAction = document.createElement('td');
            inputAction.textContent = input.action_point;
            inputRow.appendChild(inputAction);
        } else
        {
            const inputName = document.createElement('td');
            inputName.textContent = input.name;
            const inputOpinion = document.createElement('td');
            inputOpinion.textContent = input.opinion;
            inputRow.appendChild(inputName);
            inputRow.appendChild(inputOpinion);
        }

I feel this could be slightly more clear - you could make explicit the fact that the else block is implicitly testing for an opinion table. Also I was slightly confused with the input prefix with your action table items, such as inputAction and inputRow - are these related to inputs on the page?