FAC9 / the-badgerer

For the Curious Learned Badger
http://the-badgerer.herokuapp.com/
1 stars 1 forks source link

Comments #121

Open g-sam opened 7 years ago

g-sam commented 7 years ago

Nice work. Well done for getting it hosted. Some comments:

Jwhiles commented 7 years ago

Thanks for the suggestions,

could you clarify the second point? I'm not totally sure what you mean.

Jwhiles commented 7 years ago

I will say, it's not our fault if our users can't spell ;)

g-sam commented 7 years ago

re the second point, I mean you should reply inside the callback that fires after the database request has returned. Otherwise you may redirect (so the user thinks everything is fine), then suddenly an error is thrown when the db returns.

njsfield commented 7 years ago

For point 5;

Could you recommend any resources on learning good naming conventions?

g-sam commented 7 years ago

Consistency is the key. It doesn't matter what the convention is. The only thing to be aware of is that capital letters will be ignored by some operating systems so should be avoided.