search

FACG4 / nigerian-airlines

MIT License
0 stars 1 forks source link

Consider adding arrival_time to flights model #16

Open tomduggan85 opened 6 years ago

tomduggan85 commented 6 years ago

https://github.com/FACG4/nigerian-airlines/blob/bb60785ca1a4ea3d7b8a50f0d9ef8c643df6965f/server/database/models/flights.js#L21

It might be helpful to include an arrival_time field for flights. Knowing departure_time and arrival_time, you could then calculate the flight duration whenever you needed to display it to the user.

amusameh commented 6 years ago

great, I added arrival_time and deleted flight time(meant to be duration). @tomduggan85 I made a pull request that fixes all the issues.

I believe it's a great learning chance for us having a senior developer guiding us, so we are looking forward to hearing more from you as the project progress in any aspects and anywhere there is a room for improvement also any suggestions that will make us a better developers are very welcome as they say (Good is the Enemy of Great)

Thanks a million

tomduggan85 commented 6 years ago

You're welcome! I'll try to help in any way that I can. And please, feel free to send me a message any time and ask me anything.