search

FACG4 / w7-books

https://w7-books.herokuapp.com
0 stars 0 forks source link

GREAT JOB! #19

Open NouraldinS opened 6 years ago

NouraldinS commented 6 years ago

@amusameh @InassTubail @razan99 @haneenshahwan4 I'm sorry I've skipped lots of your code, this means fewer issues for you guys, so I'll compact the rest of what's in my mind in the following:

  1. You haven't checked for the token on each request, so I could change the token and nothing would happen.
  2. These issues are all relevant to you, so please look them all up:

https://github.com/FACG4/w6_Stop_Go_Cont/issues/81 https://github.com/FACG4/w6_Stop_Go_Cont/issues/80 https://github.com/FACG4/w6_Stop_Go_Cont/issues/79 https://github.com/FACG4/w6_Stop_Go_Cont/issues/77 https://github.com/FACG4/w6_Stop_Go_Cont/issues/75 https://github.com/FACG4/w6_Stop_Go_Cont/issues/74 https://github.com/FACG4/w6_Stop_Go_Cont/issues/67 https://github.com/FACG4/w6_Stop_Go_Cont/issues/66

  1. I loved your front-end error handling and showing your user the errors in a descriptive message.
  2. You've met the week's goal :clap: :fireworks:
  3. Thank you, I didn't spend the time to review your entire code because it was so relieving. Almost everything works perfectly. Just make sure to write more tests, use heroku, travis, eslint... etc.
  4. You guys honestly did a great job. Thnx!
razan99 commented 6 years ago

thank you Noureldean