FACG5 / unicornz

https://unicornz-app.herokuapp.com/
1 stars 1 forks source link

signupComponent class causes submit button to overflow #100

Open maxgerber opened 5 years ago

maxgerber commented 5 years ago

On your signup page, the form is contained within a div with a class of .signupComponent. This is causing the submit button to overflow onto the footer. I think in general, it's a good idea to refrain from hardcoding heights unless there's a good reason for it. This way, the height will be determined by the contents of your element, and won't overflow 😄

It's also absolutely normal for a footer component to run below the page - in fact it's a design pattern that people expect to scroll to reach the footer. I would consider removing this class and adding some padding to your form.