search

FACG5 / unicornz

https://unicornz-app.herokuapp.com/
1 stars 1 forks source link

Showing error messages that correspond to the number of incorrectly inputed fields #160

Closed yasminove closed 5 years ago

yasminove commented 5 years ago

On the sign up form, if the user has inputted more than one field incorrectly, your error messages do not inform him/her with all the errors.

See here what happens when I try to input three fields incorrectly:

I got ONLY one error message about the mismatching passwords:

screen shot 2018-12-09 at 11 03 28 pm

After matching the two passwords, but keeping the two incorrectly inputed values, I got only one error message about not ticking the checkbox (notice the incorrect answer in the background):

Side note: The error message needs more styling

screen shot 2018-12-09 at 11 14 28 pm

And even after ticking the checkbox, the same error message persists:

screen shot 2018-12-09 at 11 17 01 pm

I'd also recommend giving informative messages on what exactly went wrong when there is feedback. See this issue for reference: https://github.com/FACG5/unicornz/issues/154#issue-389052438

donia98 commented 5 years ago

Oh! that is because we check one by one so the message will lead you to correct a specific field after that if you click submit you will have the next input validation and so on, I think this way is correct what do you think ?!