search

FACG6 / CMSPosts

Link :
https://yourwordsapp.herokuapp.com/
0 stars 0 forks source link

End result #23

Open NouraldinS opened 5 years ago

NouraldinS commented 5 years ago

Loved the fact that you actually used Eslint and listened to it, that gives you huge scores, also liked the fact that you're using middlewares, even if incorrectly, it is better than if you had everything mushed in your routes, that'd be most unfortunate, but fortunately you haven't. Also also, it raises your score a lot that you've had your files named according to their task, i.e. get$$$, post$$$, select$$$, delete$$$ ...etc I did want to see your main CSS separated, but I'm not really sure whether was it the best practice or no, this one is up to you. Also I'm wondering why doesn't your eslint show an error when a line exceeds the length of 100 characters, but since it doesn't produce an error, then you're cool. One last thing, your script tags should be placed under the <body> not inside it. And I'd prefer if you could find a more generic way of calling your scripts as in:

// In your controller
res.render('page', { scripts: ['scriptA', 'scriptB', 'scriptC'] }
{{#each scripts}}
  <script src='/js/{{this}}.js' type='application/javascript'></script>
{{#each scripts}}

And that is all for your project. Most of it is about the styling of the code - and what is a middleware #21 -, you did well.

engshorouq commented 5 years ago

thanks a lot for your issues , really your issues is helpful and i will guide this issues @NoureldeanSaed