search

FACK1 / Countries-autoComplete

0 stars 1 forks source link

nice website, some time repeat the result. #30

Open alMutazBeAllah opened 5 years ago

alMutazBeAllah commented 5 years ago

screen shot 2018-11-22 at 9 10 42 am

mattlub commented 5 years ago

I am seeing a more serious bug when clearing the input field:

screen shot 2018-11-22 at 08 36 14
Hadeel-Salamin commented 5 years ago

it works fine locally, that happens only on heroku and I don't know why to be honest

mattlub commented 5 years ago

@Hadeel-Salamin did you update the app on Heroku when you updated it on Github?

p.s. You should be reviewing and not responding to issues yet 😅

Hadeel-Salamin commented 5 years ago

@mattlub I thought that heroku update automatically when I make any changes to my repository :o gonna check that after we done from code review :D

mattlub commented 5 years ago

@Hadeel-Salamin ok, no problem. When you update your master branch you have to push it to heroku.

This could be something to show and explain to everyone in your presentation!

FidaaHersh commented 5 years ago

Updated ,, done !! Check out :smile_cat: