search

FACN1 / PAS-MVP

Park and Sleep helps tourists navigate unconventional cities. Prototype:
https://xd.adobe.com/view/6572db59-ff24-4c55-9db7-3142e15141e5/
3 stars 0 forks source link

Setup project files #12

Closed Karyum closed 7 years ago

Karyum commented 7 years ago

related to #11 close #13

Karyum commented 7 years ago

hey @esraajb we addressed changes 1, 2, 5, 7. can you give some guidance on what num 4 should look like? we will work on testing and sorry about the big pull request.

jbesraa commented 7 years ago

see app.jsx and routes.jsx here: https://github.com/esraajb/todos-application/tree/master/src

Karyum commented 7 years ago

@esraajb we added the label blocked just because we don't want to add testing and routes on this pull request cause it just gonna make it really massive. so can you review the other requested changes so we can start opening issues and pull requests for testing and routes in an effort to keep our pull request smaller.

Karyum commented 7 years ago

@esraajb fixed cheers!

jbesraa commented 7 years ago

http://blog.andrewray.me/webpack-when-to-use-and-why/

jbesraa commented 7 years ago

read the link above. ill merge this one but make sure to change the discreption for webpack in a seprate PR.

you guys should make sure you understand WHY you use new things and WHAT they does, not only how to implemnt them.