FACN1 / easyNaz

https://easynaz.herokuapp.com/
4 stars 2 forks source link

function to add icons to the results page #132

Closed Suuuuha closed 7 years ago

Suuuuha commented 7 years ago

like in this pic below screenshot from 2017-06-04 16 12 15

m4v15 commented 7 years ago

Audio Recordings, Braille, Big Fonts, Carer, Place for Guide Dog, SMS messaging, Sign Language, Good Lighting, WheelChair Access, Disabled Parking, Disabled Toilets

Lets change good lighting to appropriate lighting

m4v15 commented 7 years ago

see: http://fontawesome.io/accessibility/

m4v15 commented 7 years ago

especially the bit with the title "If an icon is not an interactive element"

m4v15 commented 7 years ago

so how I would do it would be to loop through each accessibility option, like we currently do on the serviceInfo.hbs page

m4v15 commented 7 years ago

but then instead of <li>{{this}}</li> we want something more like

<i class="icon class" aria-hidden="true"></i>
<span class="a class which hides this from none screen readers (display:none)">{{this}}</span>
m4v15 commented 7 years ago

So we need to make a helper that takes one of our accessibilty options and converts it into the correct class to put on an icon, so

(Wheelchair Access) => "foundicon-wheelchair"

for example

m4v15 commented 7 years ago

so then in handlebars it will look like:

<i class= {{helperFunction this}} "aria-hidden="true">

AlManarah commented 7 years ago

Note: Be sure that we may need to many icons in the picture not tow or three just.