search

FACN1 / week3-javiasy

Repo to hold GOT actor app
https://facn1.github.io/week3-javiasy/
0 stars 2 forks source link

mixture of naming convention #51

Open Jbarget opened 7 years ago

Jbarget commented 7 years ago

https://github.com/FACN1/week3-javiasy/blob/master/request.js#L39-L41

Camel Case? Snake Case? Uppercase?

jwld commented 7 years ago

This was me - each of these functions did similar things, so I gave them a kind of 'category' for clarity, separated from the function name itself with an underscore.

Jbarget commented 7 years ago

ha its alright, i wasnt looking to point someone out :) Judging by your naming convention it looks to me like buildUrl could be a function that takes a type and returns a url according to that type

https://repl.it/GNnk

Jbarget commented 7 years ago

testable, DRY and fun to make

Jbarget commented 7 years ago

if you want to go over it just ask n i'll come over

jwld commented 7 years ago

Ahh yes that sounds good, I'll put it in. Thanks!