search

FACN3 / easyRep

A reporting app built with Express, React/Redux and MongoDB.
Apache License 2.0
2 stars 4 forks source link

created config file to route between production and development #26

Closed MarlenAw closed 6 years ago

MarlenAw commented 6 years ago

Reference #25

MarlenAw commented 6 years ago

@hoslack, @MynahMarie apparently I didn't push everything..Sorry for the confusion! please check the last commit

Routing in production mode in order to deploy the app to heroku

@hoslack please create a file called dev.js in the config folder and add your MONGO_URL to it

Once you guys approve and all, I'll deploy it tomorrow to heroku so Amira can see what we've done so far.

Karyum commented 6 years ago

@MarlenAw tiny change in the package-lock.json, me personally when it comes to conflicts in the package-lock.json i delete it :smile:

MarlenAw commented 6 years ago

@Karyum On it 😄 also isn't it better to add it to .gitignore from the start?

Karyum commented 6 years ago

@MarlenAw no package-lock.json will keep the versions of your dependencies that youre using so when let's say a dependency was update it won't crash your websire. you also made another merge conflict by fixing the conflict :sweat_smile:

MarlenAw commented 6 years ago

@Karyum solved it :sweat:

Karyum commented 6 years ago

I really don't see why this branch was a blocker