search

FACN3 / easyRep

A reporting app built with Express, React/Redux and MongoDB.
Apache License 2.0
2 stars 4 forks source link

Set up React, created a navbar, landing page and used Tachyons for st… #7

Closed MarlenAw closed 6 years ago

MarlenAw commented 6 years ago

…yling closes #1

Reference #1

Karyum commented 6 years ago

3 things that hurts me here in this pull request: 1) you used Create React App for the boiler plate. 2) Navbar, Landing page, React setup those 3 should be separate issues not 1 PR thats just nonsense.... 3) it's obvious that you did not do any proper planning it very obvious that you rushed a lot of things. you scrum @matthewdking he got this covered he can sort this out.

For me this feels like a bad start for a project.

sorry if im being harsh here but other people would just close this PR and make you open 3 separate issues. i'll start reviewing tommorow

MynahMarie commented 6 years ago

@Karyum I appreciate your opinions but I think you are maybe a bit too hard on us in your comments? I believe we had good reasons to start the project the way we did.

  1. Create-React-App: We think this is a pretty good boiler plate that comes with alot of functionalities out of the box. I don't understand why using this is such a problem, if it is then this should've been made clear by the mentors. My understanding is that we were encouraged to use whatever technology we see fit for completing the project. We chose to use Create-React-App as a starter point.

  2. About making 3 separate PR: I'm sorry if you consider this PR to be too much content but this is the beginning of the project and we wanted to make sure that all the team is on the same page so we created the first components together as well as doing the setup. We will be more careful to separate concerns in future PRs.

  3. "it's obvious that you did not do proper planning...": Why is that obvious? I think our README decently describes what we plan to do and our prototype is complete and clearly demonstrates what we are trying to achieve. If you have questions about our planning you are welcome to ask but please don't assume we have no plan only because you disagree on some decisions.

Please, in the future, try to keep your comments objective and try to offer solutions instead of giving such strong criticism that bring the energy of the team down. It would really help :)

Karyum commented 6 years ago

@MarlenAw @MynahMarie @hoslack can everyone approve the PR before i start reviewing?

MarlenAw commented 6 years ago

@Karyum it's been approved by everyone

MarlenAw commented 6 years ago

Fixed the changes. @Karyum please check :bowtie: