FACN3 / mashrou_ghazal

project autocomplet
http://tiny.cc/MashrouGhazal
Apache License 2.0
1 stars 0 forks source link

Git flow is fun! #17

Open veredrec opened 7 years ago

veredrec commented 7 years ago

Overall, your github flow is nice :tada:

issues I love the titles and descriptions for your issues, they show what you are working on, which is great! Don't forget to open an issue for every feature/part of code you are working on.

commits You almost always reference an issue when you commit changes, which is great! :sparkles: Don't forget that if you don't have an issue, you can open one before you commit your changes, but of course the best option is to create an issue before starting to work on something.

pull requests Your pull requests have better titles and descriptions, and most of them reference an issue. Try to assigns your team members as reviewers, so all of you go over the code before merging it. This is your chance to approve :white_check_mark: request changes :heavy_multiplication_x: or ask any question about the code :question: Please don't make any changes on master :scream: even if it seems like a small change. Every change should come from your code editor and terminal.

contributions Try to aim to split the work evenly between all of the team members. You can see the current graph here. You can do it by making sure you swap roles and laptops all the time :timer_clock:

Keep up the good work! :smile:

Amirk390 commented 7 years ago

Thanks Vered for the great feed back! :smile: Helpful tips! We gonna try our best to improve our working style even more :+1:

@prodionov @hoslack @ghassanmas

hoslack commented 7 years ago

Thanks Vared!