Closed Karyum closed 6 years ago
@ghassanmas @prodionov @hasansaad1 This PR was reverted cause @ghassanmas decided to merge his own PR without anyones review even the QA
check my comment here #13
you are overreacting, it's just the readme, please check the repos you have referenced above, was there even a PR when the readme was updated?
@ghassanmas i didn't show you the 2 projects so you could check their PRs cause for the first one there is a big comment from me saying that they should have split the pull request and for the second one they split the README into multiple issues more than that for each part of the README they contacted their PO. its not just the README as you said before an HR person comes to your project what is the first thing his going to look at ? hmmm let me guess, oh yes it's the README
Thats why I updated the readme as soon as possible. Again it's common to update the readme directly without even making a PR
@ghassanmas it's not common, actually it's not even a thing, even worse without your teammate's (@prodionov @hasansaad1 ) approval and a QA's approval. who is going to care about your code if they don't understand whats the point of the project through a good README ??
Who's going to care about my code ? There was no code in the readme...
@Karyum closing due to merge
this must be the first thing that goes into a project, before everything. a README. think of it as a country's independence document :sweat_smile: its very important:
here are some examples of READMEs from all around: https://github.com/FACN3/easyRep https://github.com/InFact-coop/LWC