FACN3 / spend500

week 7 project
0 stars 1 forks source link

Quite a few uses of strange if/else if/else's #40

Open finnhodgkin opened 6 years ago

finnhodgkin commented 6 years ago

In a few places in your codebase you're nesting if statements within the else block of an if statement, why not just use else if?

if (error) {
        console.log('error checking username', err);
      } else {
        if (result == true) {
          res.writeHead(200, { 'Content-Type': 'text/html' });
          res.end(JSON.stringify('username already exists'));
        } else {

vs

if (error) {
  // HANDLE THE ERRORS
} else if (result == true) {
  res.writeHead(200, { 'Content-Type': 'text/html' });
  res.end(JSON.stringify('username already exists'));
} else {
 THE REST
}

or even

if (error) {
  return // HANDLE THE ERRORS
} else if (result == true) {
  res.writeHead(200, { 'Content-Type': 'text/html' });
  return res.end(JSON.stringify('username already exists'));
}
// THE REST OF YOUR CODE NOT IN A BLOCK.