FACN3 / umm-el-fahem

authentication project
0 stars 0 forks source link

strict equal operator #33

Open jbesraa opened 6 years ago

jbesraa commented 6 years ago

as in this if https://github.com/FACN3/umm-el-fahem/blob/master/src/jwt_validation.js#L11, you keep using "==". for better code, use the strict equal operator "===". you can read more here https://stackoverflow.com/questions/359494/which-equals-operator-vs-should-be-used-in-javascript-comparisons

also, specifically in the if highlighted above, you could just write "!result".

hasansaad1 commented 6 years ago

:+1: fixed