FACN3 / umm-el-fahem

authentication project
0 stars 0 forks source link

Merging after 10 #39

Open matthewdking opened 6 years ago

matthewdking commented 6 years ago

23 #25 Both of these PRs were merged after 10. People start code reviewing at 10 so several people could be reviewing different versions of the project. If you have PRs in the morning you should not be merging them during this time. Your sole focus during this time should be raising issues on other students projects.

I can't stress enough how useful code review time is for your own learning. Use this time to practicec reading code and trying to understand how someone else writes code. See if you can learn anything from them or if you can pass on some of your own knowledge if you see something that could be done better.