search

FACN4 / week4_espionageProject

0 stars 0 forks source link

API KEY on github #37

Closed Karyum closed 6 years ago

Karyum commented 6 years ago

not a big deal right now, but just im raising this issue just cause anyone could take your key and use it https://github.com/FACN4/week4_espionageProject/blob/master/public/xhr.js#L20 but i guess it's fine for now since env vars haven't been taught yet

Karyum commented 6 years ago

also i love the comments on your code :heart:

DenisKent commented 6 years ago

Thanks Mario. Yeah if we had more time we would have put the api codes on the server side.