Closed fritzmg closed 5 years ago
It seems the currency-code
is dependent on the Accept-Language
for some reason. During testing for https://github.com/FACT-Finder-Web-Components/magento2-module/issues/140 I noticed that the ff-communication
block is generated with the following information:
<ff-communication currency-code="GBP" currency-country-code="de-DE" />
when using the following Accept-Language
request header:
Accept-Language: en-GB,en;q=0.8,de-AT;q=0.5,de;q=0.3
and
<ff-communication currency-code="EUR" currency-country-code="de-DE" />
when using the following Accept-Language
request header:
Accept-Language: de-AT,de;q=0.8,en-GB;q=0.5,en;q=0.3
The currency-country-code
is using the correct language setting from the store configuration - but why is the currency-code
dependent on the Accept-Language
rather than the store configuration? It should be EUR
, not GBP
for our store.
hi @fritzmg. Fix is already on Pull requests
Thank you. Do you have https://github.com/FACT-Finder-Web-Components/magento2-module/pull/84#issuecomment-509244099 in your pipeline yet as well? This feature is really important for us.
If the
Accept-Language
request header only containsde
, the following error will be generated:Seems to happen during the generation of the
<ff-communication>
block.