FACT-Finder-Web-Components / magento2-module

FACT-Finder® Web Components for Magento 2
https://web-components.fact-finder.de/
Other
11 stars 17 forks source link

Add php 8.2 and php 8.3 compatibility #468

Closed duboiss closed 2 months ago

duboiss commented 10 months ago

Because your latest commit includes "PHP version 8.1 and higher". I just replaced ~8.1.0 to ~8.1 (as your sdk) in order to authorize php 8.2 / php 8.3

Composer documentation : The ~ operator is best explained by example: ~1.2 is equivalent to >=1.2 <2.0.0, while ~1.2.3 is equivalent to >=1.2.3 <1.3.0

Rayn93 commented 10 months ago

Hi @duboiss I will test SDK with PHP v8.2 and v8.3. If everything is fine I will merge your changes.

duboiss commented 10 months ago

Hey @Rayn93 , any news ? Thanks

Rayn93 commented 9 months ago

Hi @duboiss I noticed some problems with export feature for PHP v8.3. I will try to fix it.

duboiss commented 8 months ago

@Rayn93 In case you don't have it, here one

Deprecated Functionality: mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/html/vendor/omikron/magento2-factfinder/src/Model/Filter/TextFilter.php on line 17 
Rayn93 commented 2 months ago

@duboiss Support for PHP8.2 and 8.3 for SDK v4.x was added here: https://github.com/FACT-Finder-Web-Components/magento2-module/commit/d4856cb09305ea1d5d10c743ec6a743d003170bb

duboiss commented 2 months ago

@duboiss Support for PHP8.2 and 8.3 for SDK v4.x was added here: d4856cb

Do you plan to create a new release tag ?

Rayn93 commented 2 months ago

@duboiss, yes sure. Probably next week we will prepare a new release.

duboiss commented 2 months ago

@Rayn93 up about creating this new release, thanks :)

Rayn93 commented 2 months ago

@duboiss release is ready: https://github.com/FACT-Finder-Web-Components/magento2-module/releases/tag/v4.4.0