search

FACT-Finder-Web-Components / shopware6-plugin

FACT-Finder® Web Components for Shopware 6
Other
3 stars 6 forks source link

FactFinder Plugin affects mobile view port #54

Closed breaker92 closed 3 years ago

breaker92 commented 3 years ago

If the plugin is installed it affects the mobile viewport. It seems to set the wrong width for the body-tag due to a bracket error. If I remove the following scss lines the problem does not occur anymore. https://github.com/FACT-Finder-Web-Components/shopware6-plugin/blob/93b369aee8f5fd8b42ca064e15b0c5bbf91a41c7/src/Resources/app/storefront/src/scss/_asn.scss#L53-L71 https://github.com/FACT-Finder-Web-Components/shopware6-plugin/blob/93b369aee8f5fd8b42ca064e15b0c5bbf91a41c7/src/Resources/app/storefront/src/scss/_asn.scss#L83-L85

It is comprehensible in this demo installation, http://45.11.16.43/, here only the FactFinder plugin is installed. image

a-laurowski commented 3 years ago

Hi @breaker92 and thanks for reporting, we will check this out.

a-laurowski commented 3 years ago

Hi @breaker92 it looks like this is caused by the @at-root rule. I don't know what was the reason standing behind adding it, but since they are nested in ff-asn selector, it should be valid. I removed these rules locally, build the output all.css file and override the all.css in your environment using Overrides and looks its working.

Without Overrides image

With Overrides: image