search

FACT0RN / FactWallet

The official wallet of the FACT0RN Blockchain Project based on the electrum wallet.
MIT License
5 stars 2 forks source link

BIP44_COIN_TYPE not changed #21

Closed icodeface closed 7 months ago

icodeface commented 8 months ago

Hi, i found the BIP44_COIN_TYPE in https://github.com/FACT0RN/FactWallet/blob/master/electrum/constants.py#L102 is not changed to 42069 according to https://github.com/satoshilabs/slips/blob/master/slip-0044.md

The BIP44_COIN_TYPE creates a separate subtree for every cryptocoin, avoiding reusing addresses across cryptocoins and improving privacy issues.

ReverseControl commented 8 months ago

Thank you. We will address this.

silkyjohnson1 commented 8 months ago

opened pull req