Demo Assessment - Githubissues

FACxBeamery / Tom_Thomas_7_through_9

0 stars 0 forks source link

Demo Assessment #40

Open arrested-developer opened 4 years ago

arrested-developer commented 4 years ago

User Stories

As a DEVELOPER I need to WRITE INTEGRATION TESTS FOR MY APP so that I CAN PROVE MY APP WORKS AS EXPECTED

[x] Integration tests written for one or more components using Jest and React Testing Library
[x] API data is replaced with a mock/stub where required
[x] Test files are colocated with the component being tested (e.g. MyComponent.test.js)

As a DEVELOPER I need to BUILD THE FRONTEND FIRST so that I CAN DEMONSTRATE THE FUNCTIONALITY BEFORE BUILDING THE BACKEND

[x] API calls to the backend are stubbed out for now

As a DEVELOPER I need to FOLLOW A DESIGN CAREFULLY so that MY PRODUCT MATCHES THE INITIAL DESIGNS

[x] Wireframes follow Beamery's design guidelines
[x] App design matches wireframes (or if not, there is a justifiable reason)

As a DEVELOPER I need to USE A CONSISTENT METHOD OF STYLING so that MY CODEBASE IS CONSISTENT AND MY COMPONENTS ARE STYLED

[x] Components are styled consistently
[x] Styles for each component are declared using either CSS modules or Styled Components**
[x] Inline style props are not used

As a DEVELOPER I need to WRITE HIGH QUALITY CODE so that OTHER PEOPLE AND MY FUTURE SELF CAN UNDERSTAND WHAT I WROTE

[x] Variable and function names are descriptive (they don't need to be concise, they do need to be helpful)
[x] Code is (mostly) self documenting
[ ] Team code standards are followed
[x] No eslint errors (although where necessary errors may be commented out if the reason can be justified)
[x] Logic tests make it clear what is being checked

** if you want to use this, you might want to run a technical spike first

Stretch Goals

[ ] More tests