search

FAForever / FAForeverMapEditor

A community-made map editor for the game Supreme Commander Forged Alliance
MIT License
3 stars 3 forks source link

Upgrade to Unity 2022.3 #21

Closed MrRowey closed 6 months ago

MrRowey commented 7 months ago

Closes #20 Closes #18 Closes #16

@Garanas

MrRowey commented 7 months ago

Didn't mean to yeet the licence & Structre file will re-add that back in xD

But all that is needed to Complie the Editor in Unity is the following folders below image

I've tried this multiple times now even when opening in Unity Now it doesn't even add the single files like in the base repo currently

Garanas commented 7 months ago

But the visual studio project (sln/csproj) contains all the project settings. How would one edit the code and build it without it?

Unless Unity took a different approach, of course.

MrRowey commented 7 months ago

image It uses Visual Studio Code Editor

jsut open up the Folder in VSCode and your able to edit all the files

MrRowey commented 7 months ago

Ive added back in the VS Files so they are their but it can be done via VSCode

Garanas commented 7 months ago

Just because it works via another tool doesn't mean we should drop Visual Studio - that's a separate concern, unrelated to upgrading the version of Unity

BlackYps commented 6 months ago

so uhh, how would I possiby review this immense amount of changes?

MrRowey commented 6 months ago

so uhh, how would I possiby review this immense amount of changes?

This PR has so many changes due to the major change in the Unity engine this does not include any new feature additions apart from removing the play-in-game buttons.

The Best way to probably review the changes is to try the new version of the editor for Windows which is currently available for testing https://github.com/MrRowey/FAForeverMapEditor/releases/tag/WindowsPreRelses

BlackYps commented 6 months ago

I gave the mappers time until the 19th to provide feedback, but so far I haven't heard of any issues either

MrRowey commented 6 months ago

I gave the mappers time until the 19th to provide feedback, but so far I haven't heard of any issues either

That's fine we can wait for that then we can merge it in and do the new production build