search

FAForever / FAForeverMapEditor

A community-made map editor for the game Supreme Commander Forged Alliance
MIT License
3 stars 2 forks source link

Adding New Brushes to Build Process #30

Closed MrRowey closed 2 months ago

MrRowey commented 5 months ago

Closes #29

Build process works and added the extra files https://github.com/MrRowey/FAForeverMapEditor/actions/runs/9463405473

Garanas commented 5 months ago

I'm wondering (from a security point of view) whether it is not best to add the repository as a submodule. That way you can stick to a specific commit. It provides you a way to preview the content of the submodule before updating it. Otherwise whatever is on the master branch of the repository you're including would become part of this build 🤔

MrRowey commented 5 months ago

Cherry pick a spesific commit version ?

MrRowey commented 5 months ago

would we be better off then forking that repo in the faf org that way is only updated by the faf org ?

Garanas commented 5 months ago

I don't know, @Sheikah45 what are your thoughts on this?

Sheikah45 commented 5 months ago

Either a submodule or just actually add the brushes to this repo. Checking out another uncontrolled repo isn't really good practice