search

FAForever / Neroxis-Map-Generator

MIT License
18 stars 10 forks source link

Use Pbr shader #371

Closed BlackYps closed 7 months ago

BlackYps commented 8 months ago

Uses new biomes, because the texture order is drastically different

BlackYps commented 7 months ago

We should probably replace the png with a dds. I noticed that the time it takes to compress the dds file is even longer than my machine takes for the whole map generation of a 20km map. The only open question I see is, how do we keep it editable for the future. Every time you modify a dds and resave it, the compression degrades it further. So we need an original png file somewhere. That doesn't have to be shipped in the jar.

Sheikah45 commented 7 months ago

We should probably replace the png with a dds. I noticed that the time it takes to compress the dds file is even longer than my machine takes for the whole map generation of a 20km map. The only open question I see is, how do we keep it editable for the future. Every time you modify a dds and resave it, the compression degrades it further. So we need an original png file somewhere. That doesn't have to be shipped in the jar.

How big is it as an uncompressed dds?

BlackYps commented 7 months ago

Uncompressed is 16 MB without mipmaps, 21.3 MB with mipmaps. Compressed is a quarter of these values, so 4 and 5.3

Sheikah45 commented 7 months ago

The best thing then would probably be to add the compression to dds into the build process and exclude the png from the jar

BlackYps commented 7 months ago

should the png then be saved in a different location or does that not matter?

Sheikah45 commented 7 months ago

It could be moved somewhere else or it can just be excluded from the jar using gradle config

BlackYps commented 7 months ago

I added the dds, but I don't know how to exclude the png from the jar

Sheikah45 commented 7 months ago

I excluded it and also fixed the dds export so that it would work when run from a jar and not just from source

Sheikah45 commented 7 months ago

Although it looks like determinism was broken somehow somewhere according to the failing test

Sheikah45 commented 7 months ago

Loki was still referenced in some places

BlackYps commented 7 months ago

Don't merge yet, btw. I still want to tune some water settings

BlackYps commented 7 months ago

This is finished now. It does rely on fafdevelop, so a release should wait until the next game patch.

Sheikah45 commented 7 months ago

What is the status of this now?

BlackYps commented 7 months ago

The fa release happened, so that is set. I just need to resolve the conflicts now. And we should probably make a client release with the ability to select the biome