search

FAForever / Neroxis-Map-Generator

MIT License
18 stars 10 forks source link

Fix previews #397

Closed BlackYps closed 4 months ago

BlackYps commented 4 months ago

390 had the unintended side-effect that the water in the previews looked really bad.

after #390: neroxis_map_generator_snapshot_rs3yp2lri4hec_aqeaeaqiaeaqk_preview

this branch: neroxis_map_generator_snapshot_yw3j5jzjesrgw_aqiaebqip5xeo4aahm_preview

BlackYps commented 4 months ago

I changed it from reflectance because I first thought it was refering to some material property of the terrain. But what this mask actually stores is how bright the terrain is because of the illumination of the sun. We assume a diffuse reflection here (because there is no code to calculate specular reflection).

BlackYps commented 4 months ago

We could also call it irradiance

Sheikah45 commented 4 months ago

That would work